chore: ci limits on building finsemble, and clean up #2332
Conversation
|
(auto-deploy) A deployment has been created for this Pull Request Preview linksAs part of the code review process, please ensure that you test against the following
PerformancePlease ensure that this PR does not degrade the performance of the UI. We should maintain a performance score of 95+. |
| @@ -83,13 +83,6 @@ jobs: | |||
| rsync -d -r dist \ | |||
| gs://$BUCKET_OPENFIN/tag/${{ steps.vars.outputs.TAG }} | |||
|
|
|||
| - name: Deploy (Launcher) | |||
There was a problem hiding this comment.
about time we retired this .. very old installations used to point to launcher.prod.reactivetrader.com ..
| @@ -55,17 +55,3 @@ jobs: | |||
| name: playwright-report-uat | |||
| path: packages/client/playwright-report/ | |||
| retention-days: 7 | |||
|
|
|||
There was a problem hiding this comment.
Start to wind back the relentless Credit E2E-ing we are doing atm, that I pushed directly to master a few days ago.
Web Credit seem to be working consistently, although I have done nothing to fix them - still had a few recent failures on PR branch, where the full E2E (including OpenFin) is run.
UAT deployment is the same commit as Prod, so no point in duplicating there.
| @@ -90,6 +90,7 @@ jobs: | |||
| gs://$BUCKET_OPENFIN/branch/${{ steps.vars.outputs.BRANCH }} | |||
|
|
|||
| - name: Build (Finsemble) | |||
| if: ${{ steps.vars.outputs.ENVIRONMENT == 'dev' || steps.vars.outputs.ENVIRONMENT == 'uat' }} | |||
There was a problem hiding this comment.
only build Finsemble for Dev, UAT and Prod .. and consider dropping it entirely in the new year .. if we pick it up again (unlikely), we would probably look at using the io.Connect (i.e. rebadged Glue 42) product which has superseded Finsemble now (there is a migration path, I am told).
algreasley
force-pushed
the
chore/ci-clean-up
branch
3 times, most recently
from
d327729 to
2d24cb4
Compare
algreasley
force-pushed
the
chore/ci-clean-up
branch
from
2d24cb4 to
822674e
Compare
No description provided.